WIP: feat: remove jsrsasign dependancy #356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the dependency of jsrsasign and replaces it with
https://developer.mozilla.org/en-US/docs/Web/API/Crypto/subtle
Which has reasonable browser support and a shim otherwise.
https://caniuse.com/#search=SubtleCrypto
https://github.com/vibornoff/webcrypto-shim
This change introduces two breaking changes
ValidationHandler
then you'll need to updatevalidateAtHash
to return a promiseYou should be saving up to 227kb off your bundle size with this chance since jsrsasign is completely removed. See #196
This also makes this library more compatible with downstream typescript compilers, such as when being used with Bazel's
ts_library